Properly parse and set PreferredAEADCipherSuites subpacket

bcgit · Aug 26, 2024 · 813419f · 813419f
1 parent 7324d9a
commit 813419f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketGenerator.java b/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketGenerator.java
@@ -17,6 +17,7 @@
 import org.bouncycastle.bcpg.sig.KeyFlags;
 import org.bouncycastle.bcpg.sig.NotationData;
 import org.bouncycastle.bcpg.sig.PolicyURI;
+import org.bouncycastle.bcpg.sig.PreferredAEADCiphersuites;
 import org.bouncycastle.bcpg.sig.PreferredAlgorithms;
 import org.bouncycastle.bcpg.sig.PrimaryUserID;
 import org.bouncycastle.bcpg.sig.RegularExpression;
@@ -196,10 +197,9 @@ public void setPreferredCompressionAlgorithms(boolean isCritical, int[] algorith
      * @param isCritical true if should be treated as critical, false otherwise.
      * @param algorithms array of algorithms in descending preference
      */
-    public void setPreferredAEADAlgorithms(boolean isCritical, int[] algorithms)
+    public void setPreferredAEADAlgorithms(boolean isCritical, PreferredAEADCiphersuites.Combination[] algorithms)
     {
-        packets.add(new PreferredAlgorithms(SignatureSubpacketTags.PREFERRED_AEAD_ALGORITHMS, isCritical,
-            algorithms));
+        packets.add(new PreferredAEADCiphersuites(isCritical, algorithms));
     }
 
     public void addPolicyURI(boolean isCritical, String policyUri)

diff --git a/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketVector.java b/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketVector.java
@@ -18,6 +18,7 @@
 import org.bouncycastle.bcpg.sig.KeyFlags;
 import org.bouncycastle.bcpg.sig.NotationData;
 import org.bouncycastle.bcpg.sig.PolicyURI;
+import org.bouncycastle.bcpg.sig.PreferredAEADCiphersuites;
 import org.bouncycastle.bcpg.sig.PreferredAlgorithms;
 import org.bouncycastle.bcpg.sig.PrimaryUserID;
 import org.bouncycastle.bcpg.sig.RegularExpression;
@@ -285,7 +286,7 @@ public int[] getPreferredCompressionAlgorithms()
         return ((PreferredAlgorithms)p).getPreferences();
     }
 
-    public int[] getPreferredAEADAlgorithms()
+    public PreferredAEADCiphersuites getPreferredAEADAlgorithms()
     {
         SignatureSubpacket p = this.getSubpacket(SignatureSubpacketTags.PREFERRED_AEAD_ALGORITHMS);
 
@@ -294,7 +295,8 @@ public int[] getPreferredAEADAlgorithms()
             return null;
         }
 
-        return ((PreferredAlgorithms)p).getPreferences();
+        PreferredAEADCiphersuites packet = (PreferredAEADCiphersuites) p;
+        return new PreferredAEADCiphersuites(packet.isCritical(), packet.getRawAlgorithms());
     }
 
     public int getKeyFlags()