Add LibrePGP PreferredEncryptionModes signature subpacket #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
force-pushed
the
librePgpEncryptionModes
branch
from
13847c1
to
cacd2d1
Compare
vanitasvitae
force-pushed
the
librePgpEncryptionModes
branch
from
c905198
to
896741c
Compare
…s for OpenPGP and LibrePGP
|
This PR now includes changes from #1464 Edit: The codebase still contains these two methods, which are broken:
These methods take/return a single For now I have marked these methods as broken and deprecated, but really I'd rather remove them completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to implement this in its own dedicated class to express that this is not an official OpenPGP signature subpacket.