Skip to content

Commit

Permalink
Bug: sonarcloud version and mangled multiline strings (#5)
Browse files Browse the repository at this point in the history
  • Loading branch information
DerekRoberts authored Nov 14, 2022
1 parent e24cb46 commit 3cef3a5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
npm run test:cov
dir: ${{ matrix.dir }}
repository: bcgov/nr-quickstart-typescript
sonar_args: |
sonar_args: >
-Dsonar.exclusions=**/coverage/**,**/node_modules/**
-Dsonar.organization=bcgov-nr
-Dsonar.projectKey=bcgov-nr_action-test-and-analyse_${{ matrix.dir }}
Expand Down
8 changes: 4 additions & 4 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,25 +75,25 @@ runs:
# If sonar_project_token and sonar_comment_token, then run with comments
- name: SonarCloud Scan
if: inputs.sonar_project_token && inputs.sonar_comment_token
uses: SonarSource/sonarcloud-github-action@master
uses: SonarSource/sonarcloud-github-action@v1.7
env:
GITHUB_TOKEN: ${{ inputs.sonar_comment_token }}
SONAR_TOKEN: ${{ inputs.sonar_project_token }}
with:
projectBaseDir: ${{ inputs.dir }}
args:
args: >
-Dsonar.pullrequest.github.summary_comment=true -Dsonar.project.monorepo.enabled=true
${{ inputs.sonar_args }}
# If sonar_project_token and not sonar_comment_token, then run without comments
- name: SonarCloud Scan
if: inputs.sonar_project_token && ! inputs.sonar_comment_token
uses: SonarSource/sonarcloud-github-action@master
uses: SonarSource/sonarcloud-github-action@v1.7
env:
SONAR_TOKEN: ${{ inputs.sonar_project_token }}
with:
projectBaseDir: ${{ inputs.dir }}
args:
args: >
-Dsonar.pullrequest.github.summary_comment=false -Dsonar.project.monorepo.enabled=true
${{ inputs.sonar_args }}
Expand Down

0 comments on commit 3cef3a5

Please sign in to comment.