Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using readxl, give available sheets in a message #190

Closed
ateucher opened this issue May 7, 2020 · 2 comments
Closed

When using readxl, give available sheets in a message #190

ateucher opened this issue May 7, 2020 · 2 comments
Labels
enhancement New feature or request in-progress

Comments

@ateucher
Copy link
Collaborator

ateucher commented May 7, 2020 •
edited
Loading

use readxl::excel_sheets
@boshek
Copy link
Collaborator

boshek commented May 7, 2020 •
edited
Loading

Likely could use the extension revealed here:

bcdata/R/utils.R

Line 195 in 1d7282b

file_url <- resource$url

boshek added a commit that referenced this issue May 11, 2020
@boshek
handle excel sheets WIP #190
86e1ebd
@stephhazlitt stephhazlitt added enhancement New feature or request in-progress labels May 12, 2020
boshek added a commit that referenced this issue May 13, 2020
@boshek @ateucher
handle excel sheets #190 (#191)
ad4c686 
* handle excel sheets WIP #190

* update bcdc_get_data document

* no output when sheet is provided

* add test

* Update R/utils.R

Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>

* Include original error message in read_from_url error

* add handle_excel function

* test for sheet that doesn't exist

* tweak error message to accomodate function specific errors

* increase chattiness when sheet argument is supplied

* update NEWS

Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
@boshek
Copy link
Collaborator

boshek commented May 20, 2020

Closed via #191

@boshek boshek closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ateucher @stephhazlitt @boshek