Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark some queries on merge #352

Open
boshek opened this issue Dec 21, 2024 · 0 comments
Open

Benchmark some queries on merge #352

boshek opened this issue Dec 21, 2024 · 0 comments

Comments

@boshek
Copy link
Collaborator

boshek commented Dec 21, 2024

Given recent issues like #348 it might nice to have some lightweight benchmarking of a few key queries to track possible changes (either due to changes in bcdata or changes in catalogue/bcgw stuff. We can use this issue to roughgly outline a path. Here is one idea:

Lowest lift:

  • Upon a merged PR, run a script that runs n number of queries for both tabular and spatial data that is representative of the types of queries that are possible with bcdata
  • capture the timings on these queries with bench::mark
  • appends those timings to a csv file as new rows and commit that directly into this repo
  • rinse repeat to build up a baseline of how long it would take

Stretch goals:

  • benchmark directly in a PR to evaluate a code before merging <- I think really this should only ever be done if we ever encounter a scenario where it would have been nice
  • plot benchmarks and commit a png/svg to the repo for easy visualization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant