23514 More incremental development on continuation application #743
Conversation
severinbeauvais
force-pushed
the
23514
branch
2 times, most recently
from
2f167ae
to
96e3f66
Compare
- misc cleanup - updated NameRequestInfo to support hiding NR number - updated NameRequestInfo to support hiding applicant info - created AuthorizationInformation component for step 1 - updated misc labels per designs - updated validation properties and logic - added checkmarks to summary pages - created new summary section for AB ULC info (affidavit file) - added validation and step link to summary page - added ULC help component - added help to UploadAffidavit - added expro confirmation property and updated build/parse code - removed NS from ULC computation - added Company Name to authorization page (step 0) - added Company Name to step 1 - added Authorization Information to step 1 - added / updated unit tests
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-743-4beanmcb.web.app SB says, try these:
|
- hide NR applicant info on authorization page (step 0) per latest designs
There was a problem hiding this comment.
Screenshot:
There was a problem hiding this comment.
Validation:
There was a problem hiding this comment.
(The screenshots above have the old "Alberta ULC Information" labels.)
There was a problem hiding this comment.
Screenshot:
There was a problem hiding this comment.
Screenshot:
| @@ -555,7 +556,7 @@ export default class ExtraproRegistration extends Mixins(DateMixin) { | |||
| this.isBusinessActive && | |||
| !!this.business.previousJurisdiction && | |||
| !!this.business.prevIncorporationDate && | |||
| (!this.isContinuationInAffidavitRequired || !!this.business.affidavitFileKey) && | |||
| (!this.isContinuationInAffidavitRequired || this.affidavitValid) && | |||
There was a problem hiding this comment.
It's better for the sub-component to provide its validity instead of computing it here.
There was a problem hiding this comment.
Screenshot:
There was a problem hiding this comment.
Screenshot:
| > | ||
| <!-- the director's affidavit file --> |
There was a problem hiding this comment.
This is moved to a new section below.
| // nudge icon down a bit to line up with text | ||
| margin-top: 1px; | ||
| } | ||
| } |
There was a problem hiding this comment.
I got fancy here so that the checkmark vertically aligns with the text while narrow and full-width.
There was a problem hiding this comment.
Screenshot:
There was a problem hiding this comment.
Validation:
There was a problem hiding this comment.
Screenshot (in ExpandableHelp wrapper):
There was a problem hiding this comment.
Screenshot:
There was a problem hiding this comment.
Screenshot with NR number hidden and applicant info hidden:
| @@ -354,7 +354,7 @@ export default class FilingTemplateMixin extends Mixins(AmalgamationMixin, DateM | |||
| const filing: ContinuationInFilingIF = { | |||
| header: { | |||
| name: FilingTypes.CONTINUATION_IN, | |||
| certifiedBy: this.getCertifyState.certifiedBy, | |||
| certifiedBy: this.getCertifyState.certifiedBy || undefined, // remove for authorization | |||
There was a problem hiding this comment.
Without this, we'd store "null" in the JSON, which is not accepted. When the property is undefined, the JS object->JSON mapping removes the property.
| @@ -456,6 +457,8 @@ export default class FilingTemplateMixin extends Mixins(AmalgamationMixin, DateM | |||
| // restore existing business information | |||
| if (continuationIn.foreignJurisdiction) { | |||
| const foundingDate = this.apiToDate(continuationIn.business?.foundingDate) | |||
| const exproConfirmation = (continuationIn.exproConfirmation === true) ? true | |||
| : (continuationIn.exproConfirmation === false) ? false : undefined | |||
There was a problem hiding this comment.
I tested this. It works in all 3 cases.
There was a problem hiding this comment.
NRs in Dev are broken at the moment so I can't demo this (but I tested locally).
| <NameRequestInfo | ||
| :displayNrNumber="false" | ||
| :displayApplicantInfo="false" | ||
| /> |
There was a problem hiding this comment.
Screenshot:
| @valid="authorizationInfoValid = $event" | ||
| /> | ||
| </div> | ||
| </section> |
There was a problem hiding this comment.
For screenshot, see AuthorizationInformation component above.
| Enter the Registered Office and Records Office Mailing and Delivery Addresses of the resulting | ||
| business. All addresses must be located in B.C. | ||
| Provide mailing and delivery addresses for the Registered Office and the Records Office. | ||
| All addresses must be in B.C. |
There was a problem hiding this comment.
Screenshot:
| Enter the contact information for the resulting business. The BC Business Registry will use this | ||
| to communicate with the business in the future, including sending documents and notifications. | ||
| Enter the contact information for the business. The BC Business Registry will use this to | ||
| communicate with the business in the future, including sending documents and notifications. |
There was a problem hiding this comment.
Screenshot:
| Select the effective date and time of continuation. You may pay | ||
| <strong>an additional fee of $100</strong> | ||
| to select a date up to 10 days in the future. Unless a business has special requirements, | ||
| most businesses select an immediate date and time. |
There was a problem hiding this comment.
Screenshot:
severinbeauvais
requested review from
ArwenQin,
JazzarKarim,
vysakh-menon-aot and
ketaki-deodhar
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-743-4beanmcb.web.app |
Issue #: bcgov/entity#23514
Note: there's still a work-around for testing here that will need to be removed soon (but not yet).
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).