Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23754 Deleted obsolete statement #753

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Oct 24, 2024

Issue #: bcgov/entity#23754

Description of changes:

  • app version = 5.12.11
  • deleted "upload files will be renamed" statement per Jacqueline
  • updated unit test
  • fixed some whitespace

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

- deleted "upload files will be renamed" statement per Jacqueline
- updated unit test
@@ -76,7 +76,6 @@
v-for="(document, index) in authorization.files"
:key="document.fileKey"
class="upload-file-row mt-5"
:class="{ 'mb-n2': (index < numFiles) }"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
image

After:
image


<p class="info-text font-14 mt-6 mb-0">
Uploaded files will be renamed automatically.
</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
image

After:
image

@severinbeauvais
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Oct 24, 2024

@bcgov bcgov deleted a comment from bcregistry-sre Oct 24, 2024
Copy link
Collaborator

@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@severinbeauvais severinbeauvais merged commit 3ffa8dd into bcgov:main Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants