Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24084 - Alteration Name/Type Change Logic #596

Merged
merged 2 commits into from
Nov 7, 2024
Merged

24084 - Alteration Name/Type Change Logic #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5ece4
don't show error when type changed by NR
ArwenQin Nov 6, 2024
75c2d30
update codes
ArwenQin Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.11.3",
"version": "4.11.4",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
3 changes: 2 additions & 1 deletion src/components/common/YourCompany/ChangeBusinessType.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,8 @@ export default class ChangeBusinessType extends Mixins(CommonMixin) {
}

get nameRequestRequiredError (): boolean {
if (this.isNumberedCompany) {
// Don't show the Error when the type is changed by name
if (this.isNumberedCompany || this.isEntityTypeChangedByName) {
return false
}
// Named companies to CC/CCC or ULC/CUL require a name request.
Expand Down
1 change: 1 addition & 0 deletions tests/unit/ChangeBusinessType.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ describe('Change Business Type component', () => {
}
} as EntitySnapshotIF
store.stateModel.tombstone.entityType = CorpTypeCd.BC_CCC
store.stateModel.tombstone.entityTypeChangedByName = false

const wrapper: any = mount(ChangeBusinessType, { vuetify })
wrapper.vm.isEditingType = true
Expand Down
Loading