Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ignore non carbon taxed emissions #2002

Merged
merged 7 commits into from
Oct 12, 2021

Conversation

dleard
Copy link
Contributor

@dleard dleard commented Oct 5, 2021

The emission_category_missing_fuel validation function should not throw for non carbon-taxed emission categories

@dleard dleard force-pushed the feat/ignore-non-carbon-taxed-emissions branch from 53c8f83 to 9d8d1ea Compare October 5, 2021 21:15
Copy link
Contributor

@matthieu-foucault matthieu-foucault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only ignoring emissions from non-taxed categories, we also need to ignore fuels with non-taxed emission categories

@@ -1,5 +1,6 @@
%syntax-version=1.0.0
%project=mocks
%uri=mocks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is sqitch complaining about having multiple projects without a URI? If so this one should probably be https://github.com/bcgov/cas-ciip-portal/tree/develop/mocks_schema

@dleard
Copy link
Contributor Author

dleard commented Oct 6, 2021

This is only ignoring emissions from non-taxed categories, we also need to ignore fuels with non-taxed emission categories

This validation function only checks for reported emission categories that are missing fuels. We don't have a validation for the opposite scenario (a fuel is reported where emissions in the corresponding emission category is not).

We could add a new validation function or edit this one to check for both scenarios & change the validation error message.

@dleard dleard force-pushed the feat/ignore-non-carbon-taxed-emissions branch from a09da49 to 0c61873 Compare October 7, 2021 16:11
@dleard dleard force-pushed the feat/ignore-non-carbon-taxed-emissions branch from f3c6a2f to cfdb128 Compare October 8, 2021 16:34
@matthieu-foucault
Copy link
Contributor

@dleard let's add an issue for the opposite validation, and add a attn business owner label to it. Maybe check with Hanna too to see if that is a validation that needs to be added for next year?

@dleard dleard force-pushed the feat/ignore-non-carbon-taxed-emissions branch from cfdb128 to cd2b301 Compare October 12, 2021 16:58
@dleard
Copy link
Contributor Author

dleard commented Oct 12, 2021

@dleard let's add an issue for the opposite validation, and add a attn business owner label to it. Maybe check with Hanna too to see if that is a validation that needs to be added for next year?

New Issue: #2009

@matthieu-foucault matthieu-foucault merged commit eadf23b into develop Oct 12, 2021
@matthieu-foucault matthieu-foucault deleted the feat/ignore-non-carbon-taxed-emissions branch October 12, 2021 20:50
@bc-cas-shipit bc-cas-shipit bot temporarily deployed to dev October 12, 2021 23:39 Inactive
@bc-cas-shipit bc-cas-shipit bot temporarily deployed to test November 10, 2021 18:04 Inactive
@bc-cas-shipit bc-cas-shipit bot temporarily deployed to prod November 25, 2021 22:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants