-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ignore non carbon taxed emissions #2002
Feat: ignore non carbon taxed emissions #2002
Conversation
53c8f83
to
9d8d1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only ignoring emissions from non-taxed categories, we also need to ignore fuels with non-taxed emission categories
mocks_schema/sqitch.plan
Outdated
@@ -1,5 +1,6 @@ | |||
%syntax-version=1.0.0 | |||
%project=mocks | |||
%uri=mocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is sqitch complaining about having multiple projects without a URI? If so this one should probably be https://github.com/bcgov/cas-ciip-portal/tree/develop/mocks_schema
This validation function only checks for reported emission categories that are missing fuels. We don't have a validation for the opposite scenario (a fuel is reported where emissions in the corresponding emission category is not). We could add a new validation function or edit this one to check for both scenarios & change the validation error message. |
a09da49
to
0c61873
Compare
f3c6a2f
to
cfdb128
Compare
@dleard let's add an issue for the opposite validation, and add a attn business owner label to it. Maybe check with Hanna too to see if that is a validation that needs to be added for next year? |
cfdb128
to
cd2b301
Compare
The emission_category_missing_fuel validation function should not throw for non carbon-taxed emission categories