Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: github actions migration #2155

Merged
merged 1 commit into from
Feb 16, 2023
Merged

ci: github actions migration #2155

merged 1 commit into from
Feb 16, 2023

Conversation

gurjmatharu
Copy link
Contributor

@gurjmatharu gurjmatharu commented Jan 30, 2023 •
edited
Loading

zh card

Note: added another tech debt to split this up: #2163

@gurjmatharu gurjmatharu marked this pull request as ready for review February 16, 2023 00:35
@gurjmatharu gurjmatharu force-pushed the feat/migrate-to-github branch from 242ac3b to 404b4b2 Compare February 16, 2023 00:35
dleard
dleard requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@dleard dleard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Just a small edit to the immutable sqitch changes check.

Also, it looks like codeQL found a console.log here that should be removed.

Let's squash all the 'wip' commits for a cleaner history as well.

.github/workflows/immutable-sqitch-change.yml Outdated Show resolved Hide resolved
@gurjmatharu gurjmatharu force-pushed the feat/migrate-to-github branch 2 times, most recently from 84b1e77 to dc76f00 Compare February 16, 2023 17:52
dleard
dleard previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@dleard dleard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@gurjmatharu
ci: migrating to github actions
5b44128 
chore: removing console log

chore: fixing sqitch check

chore: cleanup
@gurjmatharu gurjmatharu force-pushed the feat/migrate-to-github branch from 45894e2 to 5b44128 Compare February 16, 2023 21:08
@gurjmatharu gurjmatharu merged commit 168972a into develop Feb 16, 2023
@gurjmatharu gurjmatharu deleted the feat/migrate-to-github branch February 16, 2023 21:24
@bc-cas-shipit bc-cas-shipit bot temporarily deployed to dev February 24, 2023 17:52 Inactive
@bc-cas-shipit bc-cas-shipit bot temporarily deployed to test February 27, 2023 23:00 Inactive
@bc-cas-shipit bc-cas-shipit bot temporarily deployed to prod March 1, 2023 21:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleard dleard dleard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurjmatharu @dleard