fix: populate anyOf only if we have options #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbastia
approved these changes
Jan 3, 2025
Signed-off-by: SeSo <sobhani.sepehr@gmail.com>
Signed-off-by: SeSo <sobhani.sepehr@gmail.com>
Sepehr-Sobhani
force-pushed
the
2624-fix-new-contact-new-operation
branch
from
1310aff to
1a1f585
Compare
@pbastia Thank you for reviewing this PR! We already had tests for the contact form, and we should have caught that error earlier if we had been using the correct schema to render the component. By using the appropriate schema, an error was raised, and I was able to fix it. I added an extra test for the operation form to ensure it's working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE 2624