2563 users should not be able to add places assigned on the contacts form #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCerki
approved these changes
Jan 6, 2025
| @@ -1,7 +1,7 @@ | |||
| import { RJSFSchema } from "@rjsf/utils"; | |||
| import provinceOptions from "@bciers/data/provinces.json"; | |||
| import SectionFieldTemplate from "@bciers/components/form/fields/SectionFieldTemplate"; | |||
| import { InlineArrayFieldTemplate } from "@bciers/components/form/fields"; | |||
| import { ArrayFieldTemplate } from "@bciers/components/form/fields"; | |||
There was a problem hiding this comment.
Why is it better to use this one?
There was a problem hiding this comment.
I'm not entirely sure why it was originally used, but these two field templates are quite similar. When I used them interchangeably, they appeared identical. The only noticeable difference was the note prop, which I assume we would also need in the ArrayField. That said, I aimed to minimize the usage of InlineArrayFieldTemplate and instead reuse ArrayFieldTemplate.
Additionally, the removable prop on the ArrayFieldTemplate perfectly aligned with the requirements of this feature. I avoided modifying InlineArrayFieldTemplate to replicate the same removable prop behaviour, as it seemed unnecessary.
…form Signed-off-by: SeSo <sobhani.sepehr@gmail.com>
…ide component Signed-off-by: SeSo <sobhani.sepehr@gmail.com>
Signed-off-by: SeSo <sobhani.sepehr@gmail.com>
Sepehr-Sobhani
force-pushed
the
2563-users-should-not-be-able-to-add-places-assigned-on-the-contacts-form
branch
from
b9fb27a to
f24d49f
Compare
Sepehr-Sobhani
deleted the
2563-users-should-not-be-able-to-add-places-assigned-on-the-contacts-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE 2563