-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 + Vite migration #211
Open
skylermcnamee-hibc
wants to merge
118
commits into
main
Choose a base branch
from
vite-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not work and pdf.js does not work
cyrilbravo
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Nothing major that I see that could break the common-lib-vue. One thing I would suggest after merging this to main is to test our DE Apps that uses common-lib-vue to verify that everything is working fine. Nice work :)
This reverts commit 4eac30b.
cyrilbravo
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
npm audit
was checked, applicable vulnerabilities were updatednpm run build
passesnpm run storybook
still works (storybook as a whole still runs, individual components should have the same functionality as in Vue 2)npm run lint
has no unexpected errorsnpm run format
was run on changed filesnpm run test:e2e
) (everything passed in Chrome 126, Edge 126, Firefox 129, and Electron 118)Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
Migrates from Vue CLI/Webpack to Vue 3 + Vite. This requires some heavy-duty changes to package dependencies, configuration files, and component code. To expedite this development as well as increase ease of maintenance later, it also adds some quality-of-life tools like Husky and Prettier.
Breaking changes:
∞
)Other changes:
Additional Notes:
This PR shouldn't be merged into main until after all DE applications have been migrated to Vue 3/Vite-- this way if a critical vulnerability is discovered in the Vue 2 version of the package, the Vue 2 code will still be there in main, ready to patch and publish. However, we do need a Vue 3/Vite version of this package available for future applications, where Vue 2 support is not expected or required. My intention is to publish an alpha/pre-release version with this support to NPM in the interim period.