Ensure duplicate versions are deleted during version sync process #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimCsaky
force-pushed
the
sync
branch
2 times, most recently
from
a1cd440 to
882fb27
Compare
Coverage Report
|
|
Code Climate has analyzed commit d3b92d2 and detected 119 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 76.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 64.7% (0.0% change). View more on Code Climate. |
TimCsaky
requested review from
jujaga,
norrisng-bc and
jatindersingh93
as code owners
norrisng-bc
approved these changes
Nov 2, 2023
TimCsaky
changed the title
handle non-versioned buckets dupes where VersionId is 'null' do differential logic in javascript
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jujaga
approved these changes
Nov 6, 2023
kyle1morel
approved these changes
Nov 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has some changes to the version syncing, specifically deleting versions.
It addresses an edge case where the coms database contains multiple versions with the same S3 VersionId.
There is also a change to update 'is latest' in the version service delete() method .
we could really do with some regression testing on this before merging.
steps for testing:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments