Update pagination validation and add test cases #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
|
Code Climate has analyzed commit 61a7f01 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 66.3% (0.0% change). View more on Code Climate. |
jatindersingh93
force-pushed
the
SC3485
branch
from
3da36d9 to
85750d8
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jatindersingh93
force-pushed
the
SC3485
branch
from
85750d8 to
a738eb9
Compare
jatindersingh93
requested review from
jujaga,
norrisng-bc,
TimCsaky,
wilwong89 and
kyle1morel
as code owners
TimCsaky
reviewed
Jan 12, 2024
TimCsaky
approved these changes
Jan 12, 2024
jatindersingh93
force-pushed
the
SC3485
branch
from
a738eb9 to
8058784
Compare
jatindersingh93
force-pushed
the
SC3485
branch
from
8058784 to
61a7f01
Compare
jujaga
changed the title
jujaga
approved these changes
Jan 12, 2024
kyle1morel
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC3485
Description
Types of changes
Checklist
Further comments