Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to the invite link #257

Closed
wants to merge 1 commit into from

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Apr 16, 2024

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jatindersingh93 jatindersingh93 force-pushed the invite_permissions branch 2 times, most recently from ab94523 to d782b2e Compare April 18, 2024 22:39
Copy link

Coverage Report

Totals Coverage
Statements: 61.17% ( 3051 / 4988 )
Methods: 50.91% ( 334 / 656 )
Lines: 68.18% ( 1834 / 2690 )
Branches: 53.78% ( 883 / 1642 )

app/src/controllers/invite.js Show resolved Hide resolved
app/src/controllers/invite.js Show resolved Hide resolved
Copy link

codeclimate bot commented Apr 18, 2024

Code Climate has analyzed commit 1becb7c and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 71.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (-0.1% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 force-pushed the invite_permissions branch 2 times, most recently from 76ce859 to 77670df Compare April 19, 2024 20:30
@jatindersingh93 jatindersingh93 marked this pull request as ready for review April 19, 2024 20:33
@TimCsaky TimCsaky deleted the invite_permissions branch April 25, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant