Add permissions to the invite link #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatindersingh93
requested review from
norrisng-bc,
TimCsaky and
kyle1morel
as code owners
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 0464e89 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.1% (-0.1% change). View more on Code Climate. |
Coverage Report
|
enformce 1 required element in permCodes array prevent duplicate perms in array in db Require MANAGE permission to update a bucket update codeowners file
TimCsaky
reviewed
Apr 23, 2024
app/src/controllers/invite.js
Outdated
| instance: req.originalUrl, | ||
| bucketId: invite.resource | ||
| // Grant invitation permission and cleanup | ||
| await objectPermissionService.addPermissions(invite.resource, [ |
There was a problem hiding this comment.
fyi, the objectPermissionService.addPermissions() method can accept an array of { user,Id, permCode } objects.
eg:
await objectPermissionService.addPermissions(invite.resource, permCodes.map( p => { uswerID: userId, permCode.p }), invite.createdBy);so maybe you dont need the forEach.. but again.. maybe it's clearer the way you have it
There was a problem hiding this comment.
Its a good point, i feel like we should redo this part of the code, may be along with BCBOX?
norrisng-bc
approved these changes
Apr 23, 2024
TimCsaky
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
Further comments