Bug fix: Sync public flag on object #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7cf7aef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.1% (0.0% change). View more on Code Climate. |
Coverage Report
|
TimCsaky
commented
May 2, 2024
| lastSyncedDate: new Date().toISOString() | ||
| }, trx); | ||
|
|
||
| // if public flag changed mark as modified |
There was a problem hiding this comment.
this line is not important.
marking the object as modified does nothing.
we had intended to use the modified flag to determine if versions needed syncing as well.. but we currently always syn the versions (so long as an object exists)
jatindersingh93
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bug existed where public file would become non-public after sync.
logic we want is:
Types of changes
Checklist
Further comments