Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep existing public status after object update #261

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

TimCsaky
Copy link
Contributor

when uploading a new version or modifying metadata, let object keep existing public status in db.

Description

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

when uploading a new version or modifying metadata,
let object keep existing public status in db.
Copy link

codeclimate bot commented May 21, 2024

Code Climate has analyzed commit 0221e4b and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report

Totals Coverage
Statements: 61.1% ( 3047 / 4987 )
Methods: 50.99% ( 335 / 657 )
Lines: 68.13% ( 1830 / 2686 )
Branches: 53.65% ( 882 / 1644 )

@TimCsaky TimCsaky marked this pull request as ready for review May 22, 2024 19:20
@TimCsaky TimCsaky merged commit 5b74516 into master May 22, 2024
13 checks passed
@TimCsaky TimCsaky deleted the bug/public-default branch September 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants