Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow forward slashes in child bucket sub-path #262

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

TimCsaky
Copy link
Contributor

Description

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report

Totals Coverage
Statements: 61.1% ( 3047 / 4987 )
Methods: 50.99% ( 335 / 657 )
Lines: 68.13% ( 1830 / 2686 )
Branches: 53.65% ( 882 / 1644 )

@TimCsaky TimCsaky marked this pull request as ready for review May 27, 2024 23:35
Copy link

codeclimate bot commented May 27, 2024

Code Climate has analyzed commit 9f7d1d4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.1% (0.0% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 merged commit 3154930 into master May 29, 2024
13 checks passed
@TimCsaky TimCsaky deleted the child-bucket branch September 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants