Add database audit trigger on invite update/delete #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
Invites are deleted once used, so log this in the audit table
norrisng-bc
force-pushed
the
feature/invite-audit-trigger
branch
from
3a5860a to
3efba85
Compare
|
Code Climate has analyzed commit 3efba85 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.1% (0.0% change). View more on Code Climate. |
TimCsaky
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an invite is used, it is deleted from the
invitetable. This deletion is now logged to the audit table via a database trigger (as is already the case for other audited actions).https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3680
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
As is the case with the existing audit triggers, the new trigger will execute on updates and deletes.
At the moment, however, it effectively only runs on delete since there's no mechanism to modify invites after creation.