Reduced complexity of the new sync function

bcgov · Aug 20, 2024 · 2e9b402 · 2e9b402
1 parent b30a683
commit 2e9b402
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/apps/api/src/applicant/external-api.service.ts b/apps/api/src/applicant/external-api.service.ts
@@ -778,6 +778,21 @@ export class ExternalAPIService {
     }
   }
 
+  async slicedSync(from: string, to: string) {
+    let result: SyncApplicantsResultDTO | undefined;
+    let page = 1;
+    let failCount = 0;
+    do {
+      try {
+        result = await this.saveApplicant(from, to, page);
+      } catch (e) {
+        this.logger.error(e, `ATS-SYNC Page ${page} failed.`);
+        failCount++;
+      }
+      page = page + 5;
+    } while ((!result?.done || !!result) && failCount < 5);
+  }
+
   async getApplicants(filter: IENUserFilterAPIDTO): Promise<ApplicantSyncRO[]> {
     const { from, to, limit, skip } = filter;
     const audits: { applicant_id: string }[] = await this.ienapplicantStatusAuditRepository

diff --git a/apps/api/src/syncdata.ts b/apps/api/src/syncdata.ts
@@ -46,20 +46,7 @@ export const handler: Handler = async (event, context: Context) => {
           page = event.page;
         }
         if (process.env.PROTOTYPE_SYNC && !page) {
-          let result: SyncApplicantsResultDTO | undefined;
-          if (!page) {
-            page = 1;
-            let failCount = 0;
-            do {
-              try {
-                result = await externalAPIService.saveApplicant(from, to, page);
-              } catch (e) {
-                logger.error(e, `ATS-SYNC Page ${page} failed.`);
-                failCount++;
-              }
-              page = page + 5;
-            } while ((!result?.done || !!result) && failCount < 5);
-          }
+          await externalAPIService.saveApplicant(from, to);
         } else {
           await externalAPIService.saveApplicant(from, to, page);
         }