Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEN-943 | End-of-Journey-only milestone report #680

Closed
wants to merge 1 commit into from
Closed

Conversation

jerry-ey
Copy link
Collaborator

@jerry-ey jerry-ey commented Nov 12, 2024

Requirement

Add a separate extract that include only where a user has ended their journey (End of Journey column with a value of Journey complete/Journey incomplete)

Changes

  • most duplicate from "milestone" report code

Screenshots

  1. Frontend
    CleanShot 2024-11-12 at 11 05 10

  2. Spreadsheet - only lists if the applicant has End of Journey related milestone
    CleanShot 2024-11-12 at 11 05 41

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jerry-ey
Copy link
Collaborator Author

Quality Gate Failed Quality Gate failed

Failed conditions 22.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

I will ignore this check for this PR, as duplicating code is easier to read. And in the future, if there is new change then would not affect other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants