Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEN-941 | [Undo EoJ] Create Re-Engage milestone #687

Merged
merged 11 commits into from
Dec 11, 2024
Merged

IEN-941 | [Undo EoJ] Create Re-Engage milestone #687

merged 11 commits into from
Dec 11, 2024

Conversation

jerry-ey
Copy link
Collaborator

@jerry-ey jerry-ey commented Dec 5, 2024

AC

  • Create a new milestone - Re-engaged with IEN program
  • Create a view on the applicant details page to add/edit/remove Re-engage milestones, along with date of Re-engagement

CleanShot 2024-12-05 at 08 35 09@2x

CleanShot 2024-12-05 at 08 35 52@2x

CleanShot 2024-12-05 at 08 36 23@2x

  • Create a new permission for the ability to re-engage an applicant
    CleanShot 2024-12-05 at 08 36 51@2x

Tech changes

  • replace formik with react-hook-form for the new "system milestone form" as formik is not very actively maintained. I think it's a good time to slowly migrate to more modern approach instead of keeping using old one and not easy to maintain in the future.
  • add popular tailwind ui library shadcn/ui for consistency and easy to maintain as it applies composition design pattern in reactjs.
    Noted: the folder components/ui is copy-paste from the library which showing the power of library that it is very flexible to customize.

@jerry-ey
Copy link
Collaborator Author

jerry-ey commented Dec 5, 2024

Going to fix formatting and sonarqube.

@jerry-ey
Copy link
Collaborator Author

jerry-ey commented Dec 5, 2024

Fixed formatting and sonarQube.

Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good.
I have a few nits. One thing that I am somewhat concerned about is large chunks of stying. I don't have a clear answer on the best way to address it, but they are hard to parse, and I think hard to maintain, especially because they are decentralized. Let me know if you have any ideas.

apps/web/package.json Outdated Show resolved Hide resolved
apps/web/src/utils/milestone-utils.ts Show resolved Hide resolved
@jerry-ey
Copy link
Collaborator Author

All base UIs are from shadcn/ui site, it's maintained there. simply copy-paste. The good thing is it's not like material-ui, you can not change the source code. This shadcn/ui only guides you how to code the ui, so that you are flexible to customize.

For example: https://ui.shadcn.com/docs/components/alert
CleanShot 2024-12-10 at 08 37 15@2x

* add logic

* fix formatting

* fix correct logic

* fix version

* fix yarn.lock

* remove unused code

* fix formatting

* fix formatting

* fix any type to correct type

---------

Co-authored-by: Jerry Wang <jerryappleid761208@gmail.com>
@jerry-ey jerry-ey merged commit 7d05dc4 into main Dec 11, 2024
9 checks passed
@jerry-ey jerry-ey deleted the IEN-941 branch December 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants