-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEN-941 | [Undo EoJ] Create Re-Engage milestone #687
Conversation
Going to fix formatting and sonarqube. |
Fixed formatting and sonarQube. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good.
I have a few nits. One thing that I am somewhat concerned about is large chunks of stying. I don't have a clear answer on the best way to address it, but they are hard to parse, and I think hard to maintain, especially because they are decentralized. Let me know if you have any ideas.
All base UIs are from shadcn/ui site, it's maintained there. simply copy-paste. The good thing is it's not like material-ui, you can not change the source code. This shadcn/ui only guides you how to code the ui, so that you are flexible to customize. For example: https://ui.shadcn.com/docs/components/alert |
* add logic * fix formatting * fix correct logic * fix version * fix yarn.lock * remove unused code * fix formatting * fix formatting * fix any type to correct type --------- Co-authored-by: Jerry Wang <jerryappleid761208@gmail.com>
Quality Gate passedIssues Measures |
AC
Tech changes
formik
withreact-hook-form
for the new "system milestone form" asformik
is not very actively maintained. I think it's a good time to slowly migrate to more modern approach instead of keeping using old one and not easy to maintain in the future.Noted: the folder
components/ui
is copy-paste from the library which showing the power of library that it is very flexible to customize.