Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEN-939 | rename ncas to inspire (from user perspective) IEN-954 | Fix broken a11y workflow #698

Merged
merged 2 commits into from
Jan 14, 2025
Merged

IEN-939 | rename ncas to inspire (from user perspective) IEN-954 | Fix broken a11y workflow #698

merged 2 commits into from
Jan 14, 2025

Conversation

jerry-ey
Copy link
Collaborator

@jerry-ey jerry-ey commented Jan 8, 2025 •
edited
Loading

  • update status name from ncas to inspire in milestone table
    CleanShot 2025-01-08 at 11 03 55@2x

  • update ui on Admin page
    CleanShot 2025-01-08 at 11 04 25@2x

  • Fix broken a11y workflow (copied same fix from EHPR)

Note

  • In an enum, we cannot use variables, so we must use plain string values. That’s why we didn’t use the variable NCAS_NEW_NAME from @ien/common.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jerry-ey jerry-ey changed the title IEN-939 | rename ncas to inspire (from user perspective) IEN-939 | rename ncas to inspire (from user perspective) IEN-954 | Fix broken a11y workflow Jan 10, 2025
dbayly-freshworks
dbayly-freshworks approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jerry-ey jerry-ey merged commit 1b90e19 into main Jan 14, 2025
9 checks passed
@jerry-ey jerry-ey deleted the IEN-939 branch January 14, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbayly-freshworks dbayly-freshworks dbayly-freshworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerry-ey @dbayly-freshworks @c1495616js