-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[To Main] Feature/DESENG-445: engagement filtering by metadata #2444
[To Main] Feature/DESENG-445: engagement filtering by metadata #2444
Conversation
* DESENG-452 : Applying pending migrations * Updating unit test * Updated changelog * Fixed lint issue
* DESENG-484: Adding max age for cors (#2377)
* Provide engagement filtering options on the backend
Bring engagement filtering to met-web! --------- Co-authored-by: Baelx <16845197+Baelx@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
- Coverage 75.66% 75.58% -0.08%
==========================================
Files 577 583 +6
Lines 20563 20770 +207
Branches 1494 1526 +32
==========================================
+ Hits 15558 15699 +141
- Misses 4771 4835 +64
- Partials 234 236 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
Issue #: 🎟️DESENG-445
filter_types.py
where additional filters can be added as subquery factory functions.chips_any
andchips_all
.chips_any
: Displays as a series of toggleable buttons ("chips"), uses thelist_match_any
subquery returning engagements with any of the selected values.chips_all
: Similar to chips_any; uses thelist_match_all
subquery to get only engagements with ALL of the selected values.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).