Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] DESENG-618: Removed token from the Email verification response object #2523

Merged
merged 4 commits into from
May 23, 2024

Conversation

ratheesh-aot
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-618

Description of changes:

  • Removed verification token from the response object
  • Updated the test to reflect the change

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (3acdbcd) to head (18b1901).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2523   +/-   ##
=======================================
  Coverage   75.81%   75.81%           
=======================================
  Files         597      597           
  Lines       21432    21432           
  Branches     1575     1575           
=======================================
  Hits        16249    16249           
  Misses       4926     4926           
  Partials      257      257           
Flag Coverage Δ
metapi 87.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/met_api/services/email_verification_service.py 92.02% <100.00%> (ø)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ratheesh-aot ratheesh-aot merged commit 4993462 into main May 23, 2024
11 checks passed
@NatSquared NatSquared deleted the DESENG-618-EmailTokenFix branch June 26, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants