HEIC/HEIF image converter lambda #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex initializer, add a call to the file index initializer to call the image conversion lambda for heic files
dhlevi
approved these changes
Apr 11, 2024
|
|
||
| // if a file has a heic or heif mimetype it needs to be converted by the image | ||
| // conversion lambda rather than processed | ||
| if (fileExtension.equals("HEIC") || fileExtension.equals("HEIF") ) { |
There was a problem hiding this comment.
It'd be nice if we had a better way to detect in case there was no extension...
You can also check for the file signature. Byte 5 to 8 should give you the constant "ftyp". The following 4 bytes would be the major brand, which I believe is one of "mif1", "heic" and "heix". For example, the first 12 bytes of a .heic image would be:
00 00 00 28 66 74 79 70 6d 69 66 31
which, after removing 0s and trim the result, literally decoded to ftypmif1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the wfdm-image-converter lambda that will accept a HEIC/HEIF file and convert it to a jpg file via communication with the wfdm api.