Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system for notifications-api (part 1) #826

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

sukhpalp
Copy link
Collaborator

@sukhpalp sukhpalp commented Jul 7, 2023

No description provided.

@dhlevi
Copy link
Collaborator

dhlevi commented Jul 13, 2023

@sukhpalp Looks like there's a merge conflict to resolve
@vivid-cpreston Please give this one a review. I'd like your feedback before merging

# Conflicts:
#	.github/workflows/deploy-dev-patch.yml
#	.github/workflows/deploy-dev.yml
#	.github/workflows/deploy-test-patch.yml
#	.github/workflows/deploy-test.yml
#	.github/workflows/mvn-server-patch.yml
#	.github/workflows/mvn-server.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to rename this, since it's deploying more components than just the notifications api

@sukhpalp sukhpalp merged commit 821a24b into bcgov:main Jul 14, 2023
2 of 3 checks passed
@sukhpalp sukhpalp temporarily deployed to DEV July 14, 2023 16:31 — with GitHub Actions Inactive
@sukhpalp sukhpalp deleted the wfnews-1237 branch July 14, 2023 16:31
@sukhpalp sukhpalp temporarily deployed to DEV July 14, 2023 16:31 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants