Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #938 Remove unnecessary flows from nsgs based on security reviews. #960

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

basilv
Copy link
Collaborator

@basilv basilv commented Oct 12, 2023

No description provided.

@basilv basilv temporarily deployed to dev October 12, 2023 17:52 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 17:54 — with GitHub Actions Inactive
@basilv basilv changed the title Remove unnecessary flows from nsgs based on security reviews. fix: #938 Remove unnecessary flows from nsgs based on security reviews. Oct 12, 2023
@basilv basilv temporarily deployed to dev October 12, 2023 17:58 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 18:20 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 18:22 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 18:26 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 18:27 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 18:32 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 18:46 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 18:47 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 18:51 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 19:55 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 19:58 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 20:10 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 20:16 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 20:51 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 20:53 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 20:53 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 20:58 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 20:58 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 21:09 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 21:11 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 21:11 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 21:15 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 21:16 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 21:44 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 21:45 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 21:46 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to tools October 12, 2023 21:50 — with GitHub Actions Inactive
@basilv basilv temporarily deployed to dev October 12, 2023 21:51 — with GitHub Actions Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this code is doing what it is supposed to be doing, and the Confluence page is updated. Having said that, I'm not sure I understand all this networking stuff well enough to catch any mistakes! Approved with a warning ;-)

@MCatherine1994 MCatherine1994 merged commit 6614d74 into main Oct 16, 2023
@MCatherine1994 MCatherine1994 deleted the fix-938-restrict-nsgs branch October 16, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants