Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #938 Remove unnecessary flows from nsgs based on security reviews. #960

Merged
merged 7 commits into from
Oct 16, 2023
Merged

fix: #938 Remove unnecessary flows from nsgs based on security reviews. #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e43c25d
Remove unnecessary flows from nsgs based on security reviews.
basilv Oct 12, 2023
0a23f86
Add back data outbound - appears needed to talk to AWS secret manager
basilv Oct 12, 2023
aa11f43
Switch to explicit outbound rule for fam_app_sg
basilv Oct 12, 2023
c0d2cb7
Fix configuration of tools environment to use vanity URL
basilv Oct 12, 2023
70cf91e
Restore original rule to see if that gets tools environment working.
basilv Oct 12, 2023
09528e7
Fix tools env configuration.
basilv Oct 12, 2023
74fbfb0
Reapply the tighter security (reduced flows) for nsgs.
basilv Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 7 additions & 74 deletions infrastructure/server/network_security_groups.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,40 +9,16 @@ resource "aws_security_group" "fam_app_sg" {
managed-by = "terraform"
}

ingress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = ["10.10.32.0/20", "10.10.128.0/20"]
description = "Central VPC Traffic Inbound from Web subnets"
}

ingress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = ["10.10.0.0/19", "10.10.96.0/19"]
description = "Central VPC Traffic Inbound from App subnets"
}

ingress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = ["10.10.64.0/21", "10.10.72.0/21"]
description = "Central VPC Traffic Inbound from Mgmt subnets"
}

egress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = ["0.0.0.0/0"]
description = "Allow All Outbound Traffic"
}
}

resource "aws_vpc_security_group_egress_rule" "fam_app_sg_outbound" {
security_group_id = aws_security_group.fam_app_sg.id
cidr_ipv4 = "0.0.0.0/0"
ip_protocol = "-1"
description = "Allow All Outbound Traffic"
}


resource "aws_security_group" "fam_data_sg" {
name = "fam_data_sg"
description = "FAM custom security group for data tier."
Expand Down Expand Up @@ -70,52 +46,9 @@ resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_postgres" {
description = "Allow traffic to database from FAM application tier (lambdas)."
}

resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_central_web_a" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "10.10.32.0/20"
ip_protocol = "-1"
description = "Central VPC Traffic Inbound from Web-a"
}

resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_central_web_b" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "10.10.128.0/20"
ip_protocol = "-1"
description = "Central VPC Traffic Inbound from Web-b"
}

resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_central_app_a" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "10.10.0.0/19"
ip_protocol = "-1"
description = "Central VPC Traffic Inbound from App-a"
}

resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_central_app_b" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "10.10.96.0/19"
ip_protocol = "-1"
description = "Central VPC Traffic Inbound from App-b"
}

resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_central_mgmt_a" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "10.10.64.0/21"
ip_protocol = "-1"
description = "Central VPC Traffic Inbound from Mgmt-a"
}

resource "aws_vpc_security_group_ingress_rule" "fam_data_sg_central_mgmt_b" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "10.10.72.0/21"
ip_protocol = "-1"
description = "Central VPC Traffic Inbound from Mgmt-b"
}

resource "aws_vpc_security_group_egress_rule" "fam_data_sg_outbound" {
security_group_id = aws_security_group.fam_data_sg.id
cidr_ipv4 = "0.0.0.0/0"
ip_protocol = "-1"
description = "Allow All Outbound Traffic"
}

8 changes: 4 additions & 4 deletions terraform/tools/terragrunt.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ generate "tools_tfvars" {
prod = "${local.common_vars.inputs.idp_logout_chain_prod_url}"
tools = "${local.common_vars.inputs.idp_logout_chain_tools_url}"
}
front_end_redirect_path = "https://d3d7kmp8kmi5ix.cloudfront.net"
front_end_redirect_path = "https://fam-tools.nrs.gov.bc.ca"
fam_callback_urls = [
"https://d3d7kmp8kmi5ix.cloudfront.net/authCallback",
"https://fam-tools.nrs.gov.bc.ca/authCallback",
"http://localhost:5173/authCallback",
"http://localhost:8000/docs/oauth2-redirect",
"https://oidcdebugggersecure-c6af30-dev.apps.gold.devops.gov.bc.ca/"
]
fam_logout_urls = [
"${local.common_vars.inputs.idp_logout_chain_dev_url}https://d3d7kmp8kmi5ix.cloudfront.net",
"${local.common_vars.inputs.idp_logout_chain_dev_url}http://localhost:5173"
"${local.common_vars.inputs.idp_logout_chain_tools_url}https://fam-tools.nrs.gov.bc.ca",
"${local.common_vars.inputs.idp_logout_chain_tools_url}http://localhost:5173"
]
fam_console_idp_name = "DEV-IDIR"
forest_client_api_base_url = "https://nr-forest-client-api-test.api.gov.bc.ca"
Expand Down