Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #990 added 50 dev urls for each cognito client #996

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

MCatherine1994
Copy link
Contributor

refs: #990

@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 18:26 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 18:27 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 18:32 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 19:18 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 19:20 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 19:25 — with GitHub Actions Inactive
@ianliuwk1019
Copy link
Collaborator

Looks good!
One question, do you want to generalize the range(50) counts into a terraform variable for 50 that can be used everywhere for future clients?

@MCatherine1994
Copy link
Contributor Author

Looks good!
One question, do you want to generalize the range(50) counts into a terraform variable for 50 that can be used everywhere for future clients?

Hi Ian, I was thinking that perviously, but not sure if the client could want different range in the future....

@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 20:29 — with GitHub Actions Inactive
@ianliuwk1019
Copy link
Collaborator

Looks good!
One question, do you want to generalize the range(50) counts into a terraform variable for 50 that can be used everywhere for future clients?

Hi Ian, I was thinking that perviously, but not sure if the client could want different range in the future....

I think most likely not, but it is a variable that has default value 50. And with that the other part of this issue (github workflow change with Derek), I assume 50 is already sufficiently the upper bound. If client has specific needs, it can certainly use other number.

@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 20:31 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev October 25, 2023 20:36 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 merged commit 1286162 into main Oct 25, 2023
10 checks passed
@MCatherine1994 MCatherine1994 deleted the feat/990-add-multiple-redirect-urls branch October 25, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants