Activity UX/UI alignment #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle1morel
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
wilwong89
as code owners
kyle1morel
force-pushed
the
ux/activity-alignment
branch
from
6c7a3e9 to
c5cf2e3
Compare
Coverage Report (Frontend)
|
kyle1morel
force-pushed
the
ux/activity-alignment
branch
4 times, most recently
from
c9f0484 to
2584404
Compare
Coverage Report (Application)
|
norrisng-bc
approved these changes
Dec 29, 2023
kyle1morel
force-pushed
the
ux/activity-alignment
branch
2 times, most recently
from
b2776d5 to
2be6e62
Compare
jujaga
reviewed
Jan 2, 2024
There was a problem hiding this comment.
While we're still PoCing and changing this initial migration, I wonder if we should consider alphabetizing the columns, assuming there are no functional/business domain requirements for clustering the values together in the order they currently are.
kyle1morel
force-pushed
the
ux/activity-alignment
branch
from
2be6e62 to
68083e5
Compare
jujaga
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligns the activity view with the new UX/UI design in https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3436.
Types of changes
Checklist
Further comments