Proponent File Upload #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaytkbabu
requested review from
kyle1morel,
wilwong89 and
qhanson55
as code owners
|
Code Climate has analyzed commit 341cfc3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 41.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.9% (0.0% change). View more on Code Climate. |
Coverage Report (Frontend)
|
Coverage Report (Application)
|
sanjaytkbabu
force-pushed
the
feature/proponent-file-upload
branch
from
fb51512 to
0a71788
Compare
jujaga
reviewed
Aug 20, 2024
frontend/src/components/housing/submission/SubmissionIntakeForm.vue
Outdated
Show resolved
Hide resolved
sanjaytkbabu
force-pushed
the
feature/proponent-file-upload
branch
3 times, most recently
from
caec6db to
01f1435
Compare
sanjaytkbabu
force-pushed
the
feature/proponent-file-upload
branch
from
01f1435 to
fc9e1e8
Compare
wilwong89
approved these changes
Aug 20, 2024
kyle1morel
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proponent can select to attach a file much the same way Navigators do on the Files tab
Upon submission, the file will be stored in the Files tab for the submission.
https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-141
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments