Use sub from JWT #134
Merged
Use sub from JWT #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle1morel
requested review from
wilwong89,
sanjaytkbabu and
qhanson55
as code owners
kyle1morel
force-pushed
the
feature/jwt-sub
branch
from
2c54e01 to
253a2b9
Compare
Coverage Report (Frontend)
|
Coverage Report (Application)
|
jujaga
reviewed
Aug 22, 2024
app/src/services/user.ts
Outdated
| @@ -151,11 +151,11 @@ const service = { | |||
| * @param {string} [defaultValue=undefined] An optional default return value | |||
| * @returns {string} The current userId if applicable, or `defaultValue` | |||
| */ | |||
| getCurrentUserId: async (identityId: string, defaultValue: string | undefined = undefined) => { | |||
| getCurrentUserId: async (sub: string | undefined, defaultValue: string | undefined = undefined) => { | |||
There was a problem hiding this comment.
Type: There should never be a situation where a subject is undefined in a JWT.
JSDoc: Don't forget to update the JSDoc param names too.
app/src/controllers/enquiry.ts
Outdated
| @@ -4,7 +4,7 @@ import { generateCreateStamps, generateUpdateStamps } from '../db/utils/utils'; | |||
| import { activityService, enquiryService, noteService, userService } from '../services'; | |||
| import { Initiative } from '../utils/enums/application'; | |||
| import { ApplicationStatus, IntakeStatus, NoteType, SubmissionType } from '../utils/enums/housing'; | |||
| import { getCurrentIdentity, getCurrentTokenUsername } from '../utils/utils'; | |||
| import { getCurrentTokenSub, getCurrentTokenUsername } from '../utils/utils'; | |||
There was a problem hiding this comment.
Optional Style: It might be possible to rename to getCurrentSubject and getCurrentUsername as this information will always be inferred to have come from the JWT token.
JWT now provides the correct sub. Now using that over preffered_username. Update database and models to accuractely reflect this change.
kyle1morel
force-pushed
the
feature/jwt-sub
branch
from
253a2b9 to
8c101f4
Compare
wilwong89
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JWT now provides the correct sub. Now using that over
preffered_username. Update code, and database to accurately reflect this change.Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments