Front end document upload #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Frontend)
|
Coverage Report (Application)
|
kyle1morel
force-pushed
the
feature/file-upload-fe
branch
from
11167b1 to
ca53e7b
Compare
kyle1morel
force-pushed
the
feature/file-upload-fe
branch
from
ca53e7b to
d37a6cc
Compare
jujaga
approved these changes
Jan 16, 2024
TimCsaky
reviewed
Jan 16, 2024
| /> | ||
| </div> | ||
| <div class="col-10 p-0"> | ||
| <Carousel |
There was a problem hiding this comment.
youre probably going to want this upload ui in a separate component eventually.
I'm still questioning the need for a carousel at this stage and the complications that come with it, but good work figuring it out. The primevue component does look pretty good. Although I think we could adjust the size, spacing and default thumbnail lol.
TimCsaky
reviewed
Jan 16, 2024
TimCsaky
approved these changes
Jan 16, 2024
kyle1morel
requested review from
norrisng-bc,
jatindersingh93 and
wilwong89
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tabular view to the Submission view. New tab provides a button/drag-and-drop area for file uploading. Document uploads are done immediately, there is no confirmation button. Uploads are visible in a carousel appearing to the right of the upload area. Document upload uses COMS. A unique hash is added to the end of each filename to guarantee uniqueness.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments