Add multi-permits needed statistic #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaytkbabu
requested review from
kyle1morel,
wilwong89 and
qhanson55
as code owners
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
89ff061 to
c8effd5
Compare
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
c8effd5 to
c98c1fc
Compare
Coverage Report (Application)
|
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
c98c1fc to
a9038af
Compare
Coverage Report (Frontend)
|
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
a9038af to
9c98f41
Compare
sanjaytkbabu
changed the title
|
Release 0dd8819 deployed at https://pcns-dev-pr-140.apps.silver.devops.gov.bc.ca |
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
9c98f41 to
2e33fc4
Compare
wilwong89
reviewed
Aug 28, 2024
frontend/src/components/housing/submission/SubmissionsNavigator.vue
Outdated
Show resolved
Hide resolved
frontend/src/components/housing/submission/SubmissionsNavigator.vue
Outdated
Show resolved
Hide resolved
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
2e33fc4 to
1bb5c2f
Compare
kyle1morel
reviewed
Sep 4, 2024
Comment on lines
171
to
178
| let multiPermitsNeededCount = 0; | ||
| if (Array.isArray(permits.value)) { | ||
| permits.value.forEach((permit) => { | ||
| if (permit.activityId === sub.activityId && permit.needed?.toUpperCase() === BasicResponse.YES.toUpperCase()) { | ||
| multiPermitsNeededCount++; | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
This can be condensed
const multiPermitsNeededCount = permits.value.filter(
(x) => x.activityId === sub.activityId && x.needed?.toUpperCase() === BasicResponse.YES.toUpperCase()
).length;
kyle1morel
force-pushed
the
release/rbac
branch
from
2d4c176 to
556ae6e
Compare
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
1bb5c2f to
1514d4a
Compare
kyle1morel
force-pushed
the
release/rbac
branch
from
556ae6e to
cc2b596
Compare
sanjaytkbabu
force-pushed
the
feature/multi-auth-projects
branch
from
1514d4a to
d595f65
Compare
kyle1morel
approved these changes
Sep 4, 2024
kyle1morel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PADS-252
Multi-permits needed (Multi-Authorization Project) stats obtained (Projects with more than one permit with needed set to Yes)
rbac migration updated with statistics db function changes
list permits endpoint updated to make activityId optional
stats tab updated, submission data-table updated to show multi-auth column
multiPermitsNeeded property added to submission frontend type (this makes it easier for datatable to grab the value, also makes it sortable)
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments