Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated users in database, prevent reoccurrence #144

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

wilwong89
Copy link
Collaborator

@wilwong89 wilwong89 commented Aug 31, 2024

Description

Create a migration to remove duplicate users in the Users table.
Add a constraint at the database level for Users table to prevent duplicate users to be added to the table.

PADS-277

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 28.71% ( 1502 / 5231 )
Methods: 24.66% ( 253 / 1026 )
Lines: 32.99% ( 927 / 2810 )
Branches: 23.08% ( 322 / 1395 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 46.05% ( 945 / 2052 )
Methods: 35.62% ( 135 / 379 )
Lines: 56.71% ( 617 / 1088 )
Branches: 32.99% ( 193 / 585 )

Copy link

codeclimate bot commented Aug 31, 2024

Code Climate has analyzed commit 591b698 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 39.6% (0.0% change).

View more on Code Climate.

@wilwong89 wilwong89 force-pushed the bugfix/remove-dupe-users branch from 3b88a9e to 586307d Compare September 4, 2024 16:46
@wilwong89 wilwong89 marked this pull request as ready for review September 4, 2024 18:28
@wilwong89 wilwong89 force-pushed the bugfix/remove-dupe-users branch from 586307d to f6069d6 Compare September 4, 2024 23:10
@wilwong89 wilwong89 force-pushed the bugfix/remove-dupe-users branch from f6069d6 to 591b698 Compare September 4, 2024 23:13
@kyle1morel kyle1morel merged commit 534aab6 into master Sep 4, 2024
19 checks passed
@kyle1morel kyle1morel deleted the bugfix/remove-dupe-users branch September 4, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants