Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proponent related submissions dropdown #145

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Sep 4, 2024

Description

PADS-272
self scope is now being checked on calling getActivityIds endpoint
hasAuthorization added to the endpoint
getActivityIds function removed from service layer and instead now using getSubmissions and filtering the data in the controller
InputText replaced with EditableDropdown in enquiry intake form for related submissions

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sanjaytkbabu sanjaytkbabu changed the base branch from master to release/rbac September 4, 2024 20:55
@sanjaytkbabu sanjaytkbabu reopened this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Coverage Report (Application)

Totals Coverage
Statements: 43.92% ( 1026 / 2336 )
Methods: 32.41% ( 140 / 432 )
Lines: 54.63% ( 661 / 1210 )
Branches: 32.42% ( 225 / 694 )

@sanjaytkbabu sanjaytkbabu force-pushed the feature/proponent-related-subs branch 2 times, most recently from e233708 to ecf3400 Compare September 4, 2024 22:17
Copy link

github-actions bot commented Sep 4, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 27.49% ( 1563 / 5686 )
Methods: 23.55% ( 260 / 1104 )
Lines: 31.65% ( 964 / 3046 )
Branches: 22.07% ( 339 / 1536 )

@Subin1Doo
Copy link

Project name missing, should show Activity/ confirmation ID - Project name in the drop down.
Can we also make the dropdown show when you just click on the field itself? It only shows the dropdown when you click on the arrow. Thank you!!

app/src/controllers/submission.ts Outdated Show resolved Hide resolved
@kyle1morel kyle1morel force-pushed the feature/proponent-related-subs branch from a36317f to a47991e Compare September 5, 2024 02:54
@kyle1morel kyle1morel merged commit bab8f09 into release/rbac Sep 5, 2024
11 of 17 checks passed
@kyle1morel kyle1morel deleted the feature/proponent-related-subs branch September 5, 2024 03:09
@kyle1morel
Copy link
Collaborator

Project name missing, should show Activity/ confirmation ID - Project name in the drop down. Can we also make the dropdown show when you just click on the field itself? It only shows the dropdown when you click on the arrow. Thank you!!

Added project name. As it is an editable drop down the text area has to remain clickable to enter information. The arrow is the only way to open/close it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants