Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial user management integration with RBAC #147

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

kyle1morel
Copy link
Collaborator

Description

This is a partial implementation of the user management integrated with the new RBAC system. Time has not allowed for a full implementation and as this is not a blocker for the release the it is being merged in as is to be completed at a later date. Access to the view will be hidden.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Admin create/revoke, Supervisor create request, Supervisor revoke request. Admin approval flow and user role change not working
User management functionality is NOT complete. Merging what has been done and hiding it for now.
@kyle1morel kyle1morel changed the base branch from master to release/rbac September 5, 2024 03:14
Copy link

github-actions bot commented Sep 5, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 27.42% ( 1563 / 5701 )
Methods: 23.44% ( 259 / 1105 )
Lines: 31.56% ( 965 / 3058 )
Branches: 22.04% ( 339 / 1538 )

Copy link

github-actions bot commented Sep 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 41.36% ( 1032 / 2495 )
Methods: 31.67% ( 140 / 442 )
Lines: 51.92% ( 663 / 1277 )
Branches: 29.51% ( 229 / 776 )

@kyle1morel kyle1morel merged commit cd06eb5 into release/rbac Sep 5, 2024
17 checks passed
@kyle1morel kyle1morel deleted the feature/rbac-user-int branch September 5, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant