Document download and delete #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle1morel
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
wilwong89
as code owners
Coverage Report (Frontend)
|
Coverage Report (Application)
|
TimCsaky
approved these changes
Jan 18, 2024
| alt="document header" | ||
| src="@/assets/images/bcboxy.png" | ||
| class="document-image" | ||
| /> |
There was a problem hiding this comment.
i would try moving this to the #content template. i believe it'll make aligning the whole thing easier.
| </script> | ||
|
|
||
| <template> | ||
| <Card class="pt-2 pb-1 text-center"> |
There was a problem hiding this comment.
fyi, you can combine top and bottom padding using class py-1.
i think youre ok to remove these as they may mess with the grid layout.
| class="hover-hand hover-shadow" | ||
| @click="documentService.downloadDocument(document.documentId)" | ||
| @document:deleted=" | ||
| (documentId) => (documents = documents.filter((x: Document) => x.documentId !== documentId)) |
There was a problem hiding this comment.
This is pretty cool.
i thought you would have to remove the element from documents but i guess filtering works.
i did test this thoroughly in the browser and it all looks great
| </template> | ||
|
|
||
| <style lang="scss"> | ||
| .document-image { |
There was a problem hiding this comment.
when it comes to showing the file type icon (eg: document, image, pdf or whatever) i dont think this layout will really work.. but we'll see.
wilwong89
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements document download and delete functionality.
Cleans up the Files tab a bit - made things a bit larger, removed the border surrounding the whole thing, added hover effects
Types of changes
Checklist
Further comments