Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Submission/Enquiry draft saving endpoints #181

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Oct 4, 2024

Description

Submission & Enquiry draft endpoints updated to be

  • PUT /draft
    • to keep a draft in DRAFT status
  • PUT /draft/submit
    • finalize a draft and put it into SUBMITTED status

Param no longer required. Controller will read directly from the body and create or update data as required.
Route query is updated on save to allow for correct browser refresh.

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-298

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically appears fine other than the potential async/await issue with the Promise all mapping.

app/src/controllers/submission.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 7, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 26.6% ( 1565 / 5883 )
Methods: 21.33% ( 218 / 1022 )
Lines: 31.36% ( 913 / 2911 )
Branches: 22.26% ( 434 / 1950 )

Copy link

github-actions bot commented Oct 7, 2024

Coverage Report (Application)

Totals Coverage
Statements: 37.54% ( 943 / 2512 )
Methods: 26.32% ( 115 / 437 )
Lines: 48.87% ( 627 / 1283 )
Branches: 25.38% ( 201 / 792 )

@kyle1morel kyle1morel merged commit 4279c4f into release/interregnum Oct 7, 2024
16 of 17 checks passed
@kyle1morel kyle1morel deleted the chore/draft-endpoints branch October 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants