Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: freeze first column in submissions list; parse submission 'number of Units' data #19

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

TimCsaky
Copy link
Contributor

Description

Ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3512

  • Freeze the first column in the list view screen.
  • When pulling the Units field from SHAS into our list view, review all 3 fields and choose the one with the largest number.
  • Rename "Intake status" to "Intake state"

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 43.57% ( 61 / 140 )
Methods: 26.32% ( 5 / 19 )
Lines: 60.76% ( 48 / 79 )
Branches: 19.05% ( 8 / 42 )

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 36.73% ( 184 / 501 )
Methods: 35.29% ( 36 / 102 )
Lines: 41.05% ( 117 / 285 )
Branches: 27.19% ( 31 / 114 )

app/src/services/chefs.ts Fixed Show fixed Hide fixed
@kyle1morel kyle1morel merged commit 7398794 into master Jan 24, 2024
18 of 20 checks passed
@kyle1morel kyle1morel deleted the ux/3512 branch January 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants