Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Clean Up User Management & Add Revoke #193

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

qhanson55
Copy link
Contributor

@qhanson55 qhanson55 commented Nov 6, 2024

Description

  1. Cleaned up functionality for User Management View/ Table.
  2. Changed flow for Admin users so that they have one table for managing users and one for managing user access/revocation requests. See FIGMA
  3. Added ability to revoke users
  4. Cleaned up Create User Modal

These changes help with the functionality of user maangement table and solves refreshing issues, creates a cleaner flow for admins users, allows users' access to be revoked by Admins and Supervisors to request revocation, and better usability for creating users.

PADS-257
PADS-309

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

github-actions bot commented Nov 6, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 25.01% ( 1590 / 6358 )
Methods: 20.33% ( 223 / 1097 )
Lines: 29.46% ( 920 / 3123 )
Branches: 20.91% ( 447 / 2138 )

@qhanson55 qhanson55 force-pushed the feature/user-access-management branch from 882f943 to 3f636b5 Compare November 6, 2024 20:16
Copy link

github-actions bot commented Nov 6, 2024

Coverage Report (Application)

Totals Coverage
Statements: 36.43% ( 966 / 2652 )
Methods: 26.22% ( 118 / 450 )
Lines: 47.43% ( 647 / 1364 )
Branches: 23.99% ( 201 / 838 )

@qhanson55 qhanson55 changed the title cleaned up usermanagement functionality on backend and frontend, adde… Update/Clean Up User Management & Add Revoke Nov 6, 2024
@slhurley
Copy link
Collaborator

slhurley commented Nov 7, 2024

Is it possible to make the actual name field highlighted and ready for entry when you go into "Create new user" without having to click there first? It also looks like you can have more than one role? I thought they were elevated privileges and you could only have one role at a time? I'm not sure how I did it but at one point I had a user with 3 roles showing in the list. Also if you try to grant a role that they already have you get an Error popup but no useful error message. Biggest issue is that it seems the User Access Requests no longer works? The privileges between Admins and Supervisors seem to be exactly the same?

app/src/controllers/yars.ts Outdated Show resolved Hide resolved
app/src/routes/v1/yars.ts Outdated Show resolved Hide resolved
app/src/routes/v1/accessRequest.ts Outdated Show resolved Hide resolved
app/src/services/accessRequest.ts Outdated Show resolved Hide resolved
frontend/src/components/user/UserProcessModal.vue Outdated Show resolved Hide resolved
@qhanson55 qhanson55 force-pushed the feature/user-access-management branch from 3f636b5 to 06644f4 Compare November 8, 2024 01:34
app/src/routes/v1/yars.ts Outdated Show resolved Hide resolved
app/src/services/accessRequest.ts Outdated Show resolved Hide resolved
frontend/src/components/user/UserCreateModal.vue Outdated Show resolved Hide resolved
frontend/src/components/user/UserManageModal.vue Outdated Show resolved Hide resolved
frontend/src/services/yarsService.ts Outdated Show resolved Hide resolved
@kyle1morel
Copy link
Collaborator

General note, not asking for any changes at this time. New/update verbiage should be added to the en-CA.json file, and the text referenced via i18n. I will be asking for this to happen in future PRs.

@qhanson55 qhanson55 force-pushed the feature/user-access-management branch 2 times, most recently from 7155ce1 to 657602a Compare November 12, 2024 23:53
@qhanson55 qhanson55 force-pushed the feature/user-access-management branch from 657602a to 2a02f0d Compare November 14, 2024 18:39
@kyle1morel kyle1morel merged commit 7fa264d into release/interregnum Nov 14, 2024
16 of 17 checks passed
@kyle1morel kyle1morel deleted the feature/user-access-management branch November 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants