Usability improvements #194
Conversation
sanjaytkbabu
force-pushed
the
feature/usability-improvements
branch
from
d5daf52 to
3b2ab1b
Compare
Coverage Report (Application)
|
sanjaytkbabu
force-pushed
the
feature/usability-improvements
branch
from
3b2ab1b to
5825a74
Compare
Coverage Report (Frontend)
|
|
The hyperlink on the confirmation ID doesn't take you anywhere. It should be going to the submission itself. |
|
Can we check the spacing for "help us learn more about your housing project" section? There's too much space/ gap right now. |
sanjaytkbabu
force-pushed
the
feature/usability-improvements
branch
from
5825a74 to
29c751d
Compare
sanjaytkbabu
requested review from
kyle1morel,
wilwong89 and
qhanson55
as code owners
Confirmation ID hyperlink is fixed now. I believe as per the a/c it should say active submissions for both. |
sanjaytkbabu
force-pushed
the
feature/usability-improvements
branch
from
29c751d to
4493565
Compare
spacing adjusted! |
| <router-link :to="{ name: RouteName.HOUSING_SUBMISSIONS }">My drafts and previous entries.</router-link> | ||
| Please check your email for the confirmation email and keep the confirmation ID for future reference | ||
| </div> | ||
| <div class="mt-4"><router-link :to="{ name: RouteName.HOUSING }">Back to Housing</router-link></div> | ||
| </div> | ||
| </template> | ||
| <style scoped lang="scss"> |
There was a problem hiding this comment.
Style: There should be a newline between template and style.
| <Divider type="solid" /> | ||
| </template> | ||
| <template #content> | ||
| <div class="col-12 mt-0 pt-0 mb-0 pb-0"> |
There was a problem hiding this comment.
Precision: IIRC, you might be able to simply this to the following classes with the same results:
<div class="col-12 my-0 py-0">| </div> | ||
| </div> | ||
| </div> | ||
| <!-- eslint-disable max-len --> |
There was a problem hiding this comment.
Style: We should not be sprinkling in directives like this. This will disable checking for max-len for the rest of the file. This should only be done on a line-by-line basis.
| </div> | ||
| </div> | ||
| </template> | ||
| <style scoped lang="scss"> |
There was a problem hiding this comment.
Style: There should be a newline between template and style.
| <div class="mt-4"><router-link :to="{ name: RouteName.HOUSING }">Back to Housing</router-link></div> | ||
| </div> | ||
| </template> | ||
| <style scoped lang="scss"> |
There was a problem hiding this comment.
Style: There should be a newline between template and style.
sanjaytkbabu
force-pushed
the
feature/usability-improvements
branch
2 times, most recently
from
2a12c56 to
b1dae7b
Compare
…page changes-new routes & views
sanjaytkbabu
force-pushed
the
feature/usability-improvements
branch
from
b1dae7b to
8e39184
Compare
Description
PADS-338
New routes & views for submission & enquiry confirmation
SubmissionIntakeConfirmation component deleted
Enquiry intake form updated
Submission intake form updated
Application & Housing constants updated
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments