Fixed autosave from triggering on empty forms #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qhanson55
requested review from
kyle1morel,
wilwong89 and
sanjaytkbabu
as code owners
Coverage Report (Frontend)
|
qhanson55
force-pushed
the
bug/empty-form-autosaves
branch
from
22a65f7 to
da2ed8b
Compare
Coverage Report (Application)
|
wilwong89
reviewed
Nov 9, 2024
frontend/src/components/housing/submission/SubmissionIntakeForm.vue
Outdated
Show resolved
Hide resolved
|
Looking almost perfect! I did have one weird thing where I didn't fill out the Address section, clicked Submit and the validation occurred telling me I forgot that field...I stopped to read the red error message and it all of a sudden auto-saved and the validation went away...but I couldn't make it happen again! But I did find one error...go back and fill out the address/coordinates and click Submit and I get an Axios Error 422 (Failed to save intake) after clicking Yes to submitting so I couldn't actually submit my submission. |
qhanson55
force-pushed
the
bug/empty-form-autosaves
branch
from
da2ed8b to
ef806df
Compare
kyle1morel
reviewed
Nov 13, 2024
Comment on lines
42
to
56
| async function generateActivityId() { | ||
| try { | ||
| const response = await submissionService.updateDraft({}); | ||
| if (response.data?.activityId && response.data?.submissionId) { | ||
| emit('activityGenerated', response.data.activityId, response.data.submissionId); | ||
| return response.data.activityId; | ||
| } else { | ||
| return undefined; | ||
| } | ||
| } catch (error) { | ||
| toast.error('Failed to generate activity ID'); | ||
| return undefined; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a lot of logic unrelated to file uploading. Can this be moved to the intake form?
jujaga
reviewed
Nov 14, 2024
qhanson55
force-pushed
the
bug/empty-form-autosaves
branch
from
ef806df to
e10bdc8
Compare
qhanson55
force-pushed
the
bug/empty-form-autosaves
branch
from
e10bdc8 to
37e97ba
Compare
wilwong89
approved these changes
Nov 15, 2024
kyle1morel
approved these changes
Nov 18, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When changing steps in the submission intake form autosave is no longer triggered, onBlur for phone number doesn't trigger autosave anymore, and no more double autosave on initial save of draft.
Keeps empty drafts from cluttering the draft and submissions table.
PADS-337
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist