Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Tracker - Status description modal #197

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

Description

Permit Tracker - Status description modal

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Nov 20, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.77% ( 1605 / 6479 )
Methods: 20.34% ( 226 / 1111 )
Lines: 29.37% ( 931 / 3170 )
Branches: 20.38% ( 448 / 2198 )

Copy link

github-actions bot commented Nov 20, 2024

Coverage Report (Application)

Totals Coverage
Statements: 36.54% ( 971 / 2657 )
Methods: 26.22% ( 118 / 450 )
Lines: 47.63% ( 652 / 1369 )
Branches: 23.99% ( 201 / 838 )

qhanson55
qhanson55 previously approved these changes Nov 21, 2024
DENIED = 'Denied',
GRANTED = 'Granted',
PENDING = 'Pending',
Copy link
Contributor

@qhanson55 qhanson55 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pending can be removed now?
please match what kyle has gone with in PR-198

@qhanson55 qhanson55 dismissed their stale review November 21, 2024 17:11

please match kyle's constants/enums for AuthorizationStatus

Copy link
Contributor

@qhanson55 qhanson55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See wilson's PR-199 for the PermitAuthorizationStatusDescriptions enum as well

@sanjaytkbabu sanjaytkbabu force-pushed the feature/tracker-status-desc branch from 1ec53eb to 67713d3 Compare November 21, 2024 22:07
@kyle1morel kyle1morel merged commit bd52751 into release/interregnum Nov 21, 2024
16 of 17 checks passed
@kyle1morel kyle1morel deleted the feature/tracker-status-desc branch November 21, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants