Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional permit entries started and not finished causes error #209

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

qhanson55
Copy link
Contributor

@qhanson55 qhanson55 commented Dec 3, 2024

Description

Empty optional permits no longer error out on submission.
Helps with flow
PADS-390

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NOTE: Also fixed issue with confirmation email sending and removed function variables that matched the component's props.

Copy link

github-actions bot commented Dec 3, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.65% ( 1641 / 6656 )
Methods: 19.96% ( 227 / 1137 )
Lines: 29.23% ( 957 / 3274 )
Branches: 20.36% ( 457 / 2245 )

Copy link

github-actions bot commented Dec 3, 2024

Coverage Report (Application)

Totals Coverage
Statements: 36.25% ( 1047 / 2888 )
Methods: 24.6% ( 123 / 500 )
Lines: 47.55% ( 698 / 1468 )
Branches: 24.57% ( 226 / 920 )

@kyle1morel kyle1morel merged commit cc9b501 into master Dec 3, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the bug/optional-permit-entries branch December 3, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants