Feat: Add placeholder icons for file upload preview #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
not sure why.. but an file.xlsx i uploaded is showing with the 'image' icon. .. separate conversation but i wonder if we should base the icon on the mimeType (https://www.digipres.org/formats/mime-types/) which is available in pcns db. |
wilwong89
force-pushed
the
feat/list-attach-docs
branch
from
520723a to
df572e2
Compare
wilwong89
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
kyle1morel
as code owners
Moved logic for mimetype detection to a utils function. Files changed: utils.ts DocumentCard.vue
wilwong89
force-pushed
the
feat/list-attach-docs
branch
from
a8e4d53 to
3daeba4
Compare
kyle1morel
reviewed
Jan 25, 2024
kyle1morel
reviewed
Jan 25, 2024
kyle1morel
approved these changes
Jan 25, 2024
wilwong89
force-pushed
the
feat/list-attach-docs
branch
from
3ca0ca9 to
5a8c935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the screen displaying uploaded files, have a placeholder image preview of the file based on file extension.
Several SVG files uploaded
DocumentCard.vue component updated to display different svg placeholder based on extension
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments