Create CHES email api logging functionality #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Frontend)
|
Coverage Report (Application)
|
wilwong89
force-pushed
the
feature/email-logging
branch
from
81a035d to
afe72b3
Compare
wilwong89
requested review from
kyle1morel,
sanjaytkbabu and
qhanson55
as code owners
qhanson55
reviewed
Dec 13, 2024
qhanson55
reviewed
Dec 13, 2024
qhanson55
reviewed
Dec 13, 2024
wilwong89
force-pushed
the
feature/email-logging
branch
from
afe72b3 to
eaf2afd
Compare
kyle1morel
reviewed
Dec 16, 2024
app/src/services/email.ts
Outdated
| to: Array<string>; | ||
| }; | ||
|
|
||
| type Email_data = { |
There was a problem hiding this comment.
Type names should be in title case.
There was a problem hiding this comment.
Changed to title case
qhanson55
reviewed
Dec 16, 2024
wilwong89
force-pushed
the
feature/email-logging
branch
from
eaf2afd to
a7fa2b2
Compare
qhanson55
approved these changes
Dec 17, 2024
sanjaytkbabu
approved these changes
Dec 17, 2024
wilwong89
force-pushed
the
feature/email-logging
branch
from
a7fa2b2 to
ff16f98
Compare
Create email_log table Create typescript EmailLog types Create service function for logging Add log function to email service functions
wilwong89
force-pushed
the
feature/email-logging
branch
from
ff16f98 to
07f28d5
Compare
kyle1morel
reviewed
Dec 18, 2024
| // Create public schema tables | ||
| knex.schema | ||
| .createTable('email_log', (table) => { | ||
| table.uuid('email_id').primary(); |
There was a problem hiding this comment.
PK's should share the name of the table. email_log_id
app/src/services/email.ts
Outdated
| @@ -1,9 +1,20 @@ | |||
| import axios from 'axios'; | |||
| import config from 'config'; | |||
| import prisma from '../db/dataConnection'; | |||
There was a problem hiding this comment.
1st party import should be separate from 3rd party
There was a problem hiding this comment.
Moved import down to be separate.
wilwong89
force-pushed
the
feature/email-logging
branch
from
30b8463 to
7584cac
Compare
kyle1morel
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log CHES API calls to allow following up sent/unsent emails
Create email_log table
Create typescript EmailLog types
Create service function for logging
Add log function to email service functions
Add unit tests for logging functionality
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments